netdev - Re: [RFC net-next v1 1/1] e1000e: Introduce private flag and module param to disable K1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250730170641.208bbce5@kernel.org>
Date: Wed, 30 Jul 2025 17:06:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: "Lifshits, Vitaly" <vitaly.lifshits@...el.com>, Simon Horman
 <horms@...nel.org>, "Ruinskiy, Dima" <dima.ruinskiy@...el.com>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
 <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: Re: [RFC net-next v1 1/1] e1000e: Introduce private flag and module
 param to disable K1

On Wed, 30 Jul 2025 15:10:45 -0700 Jacob Keller wrote:
> > FWIW I will still object. The ethtool priv flag is fine, personally 
> > I don't have a strong preference on devlink vs ethtool priv flags.
> > But if you a module param you'd need a very strong justification..  
> 
> I think just the ethtool private flag is sufficient. The primary
> downside appears to be the "inability" to easily set the flag at boot,
> but...

I haven't played with udev in a while but it used to have the ability
to run a command / script when device appears. So that'd be my first
choice if how to hook the setting in when device is probed.