netdev - Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250730181645.6d818d6a@kernel.org>
Date: Wed, 30 Jul 2025 18:16:45 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Bence Csókás <csokas.bence@...lan.hu>, Andrew Lunn
 <andrew@...n.ch>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Sergei Shtylyov
 <sergei.shtylyov@...entembedded.com>, "David S. Miller"
 <davem@...emloft.net>, Rob Herring <robh@...nel.org>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, "Dmitry Torokhov"
 <dmitry.torokhov@...il.com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Csaba Buday <buday.csaba@...lan.hu>, Heiner
 Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO

On Mon, 28 Jul 2025 17:34:55 +0200 Bence Csókás wrote:
> Commit bafbdd527d56 ("phylib: Add device reset GPIO support") removed
> devm_gpiod_get_optional() in favor of the non-devres managed
> fwnode_get_named_gpiod(). When it was kind-of reverted by commit
> 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()"), the devm
> functionality was not reinstated. Nor was the GPIO unclaimed on device
> remove. This leads to the GPIO being claimed indefinitely, even when the
> device and/or the driver gets removed.
> 
> Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
> Fixes: 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()")
> Cc: Csaba Buday <buday.csaba@...lan.hu>
> Signed-off-by: Bence Csókás <csokas.bence@...lan.hu>

Looks like this is a v2 / rewrite of 
https://lore.kernel.org/all/20250709133222.48802-3-buday.csaba@prolan.hu/
? Please try to include more of a change log / history of the changes
(under the --- marker)

Andrew, you acked what I'm guessing was the v1, still looks good?