netdev - Re: [PATCH net] net/packet: fix a race in packet_set_ring() and packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <688bd9e3db0_28448c2941d@willemb.c.googlers.com.notmuch>
Date: Thu, 31 Jul 2025 17:02:27 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 netdev@...r.kernel.org
Cc: davem@...emloft.net, 
 kuba@...nel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 horms@...nel.org, 
 Willem de Bruijn <willemb@...gle.com>, 
 stable@...r.kernel.org, 
 Quang Le <quanglex97@...il.com>
Subject: Re: [PATCH net] net/packet: fix a race in packet_set_ring() and
 packet_notifier()

Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> When packet_set_ring() releases po->bind_lock, another thread can
> run packet_notifier() and process an NETDEV_UP event.
> 
> This race and the fix are both similar to that of commit 15fe076edea7
> ("net/packet: fix a race in packet_bind() and packet_notifier()").
> 
> There too the packet_notifier NETDEV_UP event managed to run while a
> po->bind_lock critical section had to be temporarily released. And
> the fix was similarly to temporarily set po->num to zero to keep
> the socket unhooked until the lock is retaken.
> 
> The po->bind_lock in packet_set_ring and packet_notifier precede the
> introduction of git history.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@...r.kernel.org
> Signed-off-by: Quang Le <quanglex97@...il.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

The From: author attribution is incorrect.

I will resubmit (after the customary 24 hrs).