netdev - Re: [PATCH bpf-next 2/5] net/smc: fix UAF on smcsk after smc_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <174ccf57-6e7c-4dab-8743-33989829de01@linux.ibm.com>
Date: Thu, 31 Jul 2025 14:57:31 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: "D. Wythe" <alibuda@...ux.alibaba.com>, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
        pabeni@...hat.com, song@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        yhs@...com, edumazet@...gle.com, john.fastabend@...il.com,
        kpsingh@...nel.org, jolsa@...nel.org, Mahanta.Jambigi@....com,
        Sidraya.Jayagond@....com, wenjia@...ux.ibm.com,
        dust.li@...ux.alibaba.com, tonylu@...ux.alibaba.com,
        guwen@...ux.alibaba.com
Cc: bpf@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, jaka@...ux.ibm.com
Subject: Re: [PATCH bpf-next 2/5] net/smc: fix UAF on smcsk after
 smc_listen_out()



On 31.07.25 10:42, D. Wythe wrote:
> BPF CI testing report a UAF issue:
> 
[..]
> 
> Fixes: 3b2dec2603d5 ("net/smc: restructure client and server code in af_smc")
> Signed-off-by: D. Wythe <alibuda@...ux.alibaba.com>
> Reviewed-by: Guangguan Wang <guangguan.wang@...ux.alibaba.com>
> ---
>  net/smc/af_smc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 1882bab8e00e..dc72ff353813 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -2568,8 +2568,9 @@ static void smc_listen_work(struct work_struct *work)
>  			goto out_decl;
>  	}
>  
> -	smc_listen_out_connected(new_smc);
>  	SMC_STAT_SERV_SUCC_INC(sock_net(newclcsock->sk), ini);
> +	/* smc_listen_out() will release smcsk */
> +	smc_listen_out_connected(new_smc);
>  	goto out_free;
>  
>  out_unlock:


As this is a problem fix, you could send it directly to 'net'
instead of including it to this series.

Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>