[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250731153502.78eebb88@fedora.home>
Date: Thu, 31 Jul 2025 15:35:02 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
thomas.petazzoni@...tlin.com, Jakub Kicinski <kuba@...nel.org>, Eric
Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell
King <linux@...linux.org.uk>, linux-arm-kernel@...ts.infradead.org,
Christophe Leroy <christophe.leroy@...roup.eu>, Herve Codina
<herve.codina@...tlin.com>, Florian Fainelli <f.fainelli@...il.com>, Heiner
Kallweit <hkallweit1@...il.com>, Vladimir Oltean <vladimir.oltean@....com>,
Köry Maincent <kory.maincent@...tlin.com>, Marek
Behún <kabel@...nel.org>, Oleksij Rempel
<o.rempel@...gutronix.de>, Nicolò Veronese
<nicveronese@...il.com>, Simon Horman <horms@...nel.org>,
mwojtas@...omium.org, Antoine Tenart <atenart@...nel.org>,
devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>, Krzysztof
Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Romain
Gantois <romain.gantois@...tlin.com>, Daniel Golle <daniel@...rotopia.org>,
Dimitri Fedrau <dimitri.fedrau@...bherr.com>
Subject: Re: [PATCH net-next v10 01/15] dt-bindings: net: Introduce the
ethernet-connector description
Hello Andrew,
First, thanks a lot for taking a look a this series !
On Sat, 26 Jul 2025 21:49:07 +0200
Andrew Lunn <andrew@...n.ch> wrote:
> > - The number of lanes, which is a quite generic property that allows
> > differentating between multiple similar technologies such as BaseT1
> > and "regular" BaseT (which usually means BaseT4).
>
> > + mdi {
> > + connector-0 {
> > + lanes = <2>;
> > + media = "BaseT";
>
> This is correct when the port is Fast Ethernet. However, as you point
> out, now a days, the more normal case is 1G, with 4 lanes for BaseT.
> To avoid developers just copy/pasting without engaging brain, maybe
> add a comment about it being a Fast Ethernet port?
Absolutely :)
Maxime
>
> Andrew
Powered by blists - more mailing lists