netdev - Re: [PATCH net] net/mlx5: Correctly set gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175408441027.4089984.2960748466316299557.git-patchwork-notify@kernel.org>
Date: Fri, 01 Aug 2025 21:40:10 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Christoph Paasch <cpaasch@...nai.com>
Cc: saeedm@...dia.com, tariqt@...dia.com, mbloch@...dia.com, leon@...nel.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, amirv@...lanox.com,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org, gal@...dia.com
Subject: Re: [PATCH net] net/mlx5: Correctly set gso_segs when LRO is used

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue, 29 Jul 2025 11:34:00 -0700 you wrote:
> From: Christoph Paasch <cpaasch@...nai.com>
> 
> When gso_segs is left at 0, a number of assumptions will end up being
> incorrect throughout the stack.
> 
> For example, in the GRO-path, we set NAPI_GRO_CB()->count to gso_segs.
> So, if a non-LRO'ed packet followed by an LRO'ed packet is being
> processed in GRO, the first one will have NAPI_GRO_CB()->count set to 1 and
> the next one to 0 (in dev_gro_receive()).
> Since commit 531d0d32de3e
> ("net/mlx5: Correctly set gso_size when LRO is used")
> these packets will get merged (as their gso_size now matches).
> So, we end up in gro_complete() with NAPI_GRO_CB()->count == 1 and thus
> don't call inet_gro_complete(). Meaning, checksum-validation in
> tcp_checksum_complete() will fail with a "hw csum failure".
> 
> [...]

Here is the summary with links:
  - [net] net/mlx5: Correctly set gso_segs when LRO is used
    https://git.kernel.org/netdev/net/c/77bf1c55b2ac

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html