netdev - Re: [RFC v1 01/22] docs: ethtool: document that rx_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250801161326.6dd670be@kernel.org>
Date: Fri, 1 Aug 2025 16:13:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: Pavel Begunkov <asml.silence@...il.com>, netdev@...r.kernel.org,
 io-uring@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Willem de
 Bruijn <willemb@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 andrew+netdev@...n.ch, horms@...nel.org, davem@...emloft.net,
 sdf@...ichev.me, dw@...idwei.uk, michael.chan@...adcom.com,
 dtatulea@...dia.com, ap420073@...il.com
Subject: Re: [RFC v1 01/22] docs: ethtool: document that rx_buf_len must
 control payload lengths

On Mon, 28 Jul 2025 14:36:37 -0700 Mina Almasry wrote:
> > +``ETHTOOL_A_RINGS_RX_BUF_LEN`` controls the size of the buffer chunks driver
> > +uses to receive packets. If the device uses different memory polls for headers
> > +and payload this setting may control the size of the header buffers but must
> > +control the size of the payload buffers.
> > +  
> 
> To be honest I'm not a big fan of the ambiguity here? Could this
> configure just the payload buffer sizes? And a new one to configure
> the header buffer sizes eventually?
> 
> Also, IIUC in this patchset, actually the size applied will be the
> order that is larger than the size configured, no? So a setting of 9KB
> will actually result in 16KB, no? Should this be documented? Or do we
> expect non power of 2 sizes to be rejected by the driver and this API
> fail?

This is an existing parameter.