netdev - Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] ixgbe: prevent from unwanted interface name changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <934e0690-d080-4d01-8041-394de0546e03@intel.com>
Date: Fri, 1 Aug 2025 16:29:26 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>,
	<dhowells@...hat.com>, <David.Kaplan@....com>, <jiri@...nulli.us>,
	<przemyslaw.kitszel@...el.com>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] ixgbe: prevent from
 unwanted interface name changes



On 7/7/2025 1:58 AM, Jedrzej Jagielski wrote:
> Users of the ixgbe driver report that after adding devlink
> support by the commit a0285236ab93 ("ixgbe: add initial devlink support")
> their configs got broken due to unwanted changes of interfaces names.
> It's caused by changing names by devlink port initialization flow.
> 
> To prevent from that set skip_phys_port_name_get flag for ixgbe
> devlink ports.
> 

I thought this had been discussed on other devices, and the consensus
had been that this is not the kernel fault.

> Reported-by: David Howells <dhowells@...hat.com>
> Closes: https://lkml.org/lkml/2025/4/24/2052
> Reported-by: David Kaplan <David.Kaplan@....com>
> Closes: https://www.spinics.net/lists/netdev/msg1099410.html
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Acked-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Fixes: a0285236ab93 ("ixgbe: add initial devlink support")
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v2: use new flag instead of creating blank implementation of
>     ndo_get_phys_port_name()
> ---
>  drivers/net/ethernet/intel/ixgbe/devlink/devlink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c b/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
> index 54f1b83dfe42..47fae5035b9f 100644
> --- a/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
> @@ -543,6 +543,7 @@ int ixgbe_devlink_register_port(struct ixgbe_adapter *adapter)
>  
>  	attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
>  	attrs.phys.port_number = adapter->hw.bus.func;
> +	attrs.skip_phys_port_name_get = 1;

The use of an attribute here is a lot nicer than filling in a custom
ndo_get_phys_port_name() option, I agree.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  	ixgbe_devlink_set_switch_id(adapter, &attrs.switch_id);
>  
>  	devlink_port_attrs_set(devlink_port, &attrs);



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)