[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250801092410.GD14753@horms.kernel.org>
Date: Fri, 1 Aug 2025 10:24:10 +0100
From: Simon Horman <horms@...nel.org>
To: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, anthony.l.nguyen@...el.com,
netdev@...r.kernel.org,
Aleksandr Loktionov <aleksandr.loktionov@...el.com>
Subject: Re: [PATCH iwl-net v2] ixgbe: fix ixgbe_orom_civd_info struct layout
On Thu, Jul 31, 2025 at 02:45:33PM +0200, Jedrzej Jagielski wrote:
> The current layout of struct ixgbe_orom_civd_info causes incorrect data
> storage due to compiler-inserted padding. This results in issues when
> writing OROM data into the structure.
>
> Add the __packed attribute to ensure the structure layout matches the
> expected binary format without padding.
>
> Fixes: 70db0788a262 ("ixgbe: read the OROM version information")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v2: use get_unaligned_le32() per Simon's suggestion
Thanks for the update.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists