netdev - Re: [PATCH net] benet: fix BUG when creating VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04b0f2b9-1aa5-49e6-9522-80df7a8f1a45@blackwall.org>
Date: Fri, 1 Aug 2025 13:24:50 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Michal Schmidt <mschmidt@...hat.com>,
 Ajit Khaparde <ajit.khaparde@...adcom.com>,
 Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
 Somnath Kotur <somnath.kotur@...adcom.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] benet: fix BUG when creating VFs

On 8/1/25 13:13, Michal Schmidt wrote:
> benet crashes as soon as SRIOV VFs are created:
> 
>  kernel BUG at mm/vmalloc.c:3457!
>  Oops: invalid opcode: 0000 [#1] SMP KASAN NOPTI
>  CPU: 4 UID: 0 PID: 7408 Comm: test.sh Kdump: loaded Not tainted 6.16.0+ #1 PREEMPT(voluntary)
>  [...]
>  RIP: 0010:vunmap+0x5f/0x70
>  [...]
>  Call Trace:
>   <TASK>
>   __iommu_dma_free+0xe8/0x1c0
>   be_cmd_set_mac_list+0x3fe/0x640 [be2net]
>   be_cmd_set_mac+0xaf/0x110 [be2net]
>   be_vf_eth_addr_config+0x19f/0x330 [be2net]
>   be_vf_setup+0x4f7/0x990 [be2net]
>   be_pci_sriov_configure+0x3a1/0x470 [be2net]
>   sriov_numvfs_store+0x20b/0x380
>   kernfs_fop_write_iter+0x354/0x530
>   vfs_write+0x9b9/0xf60
>   ksys_write+0xf3/0x1d0
>   do_syscall_64+0x8c/0x3d0
> 
> be_cmd_set_mac_list() calls dma_free_coherent() under a spin_lock_bh.
> Fix it by freeing only after the lock has been released.
> 
> Fixes: 1a82d19ca2d6 ("be2net: fix sleeping while atomic bugs in be_ndo_bridge_getlink")
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/net/ethernet/emulex/benet/be_cmds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
> index d730af4a50c7..bb5d2fa15736 100644
> --- a/drivers/net/ethernet/emulex/benet/be_cmds.c
> +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
> @@ -3856,8 +3856,8 @@ int be_cmd_set_mac_list(struct be_adapter *adapter, u8 *mac_array,
>  	status = be_mcc_notify_wait(adapter);
>  
>  err:
> -	dma_free_coherent(&adapter->pdev->dev, cmd.size, cmd.va, cmd.dma);
>  	spin_unlock_bh(&adapter->mcc_lock);
> +	dma_free_coherent(&adapter->pdev->dev, cmd.size, cmd.va, cmd.dma);
>  	return status;
>  }
>  

Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>