netdev - Re: [RFC PATCH v2] ethtool: add FEC bins histogramm report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e995c4d-8245-4e47-88fb-6a735dbc0dda@linux.dev>
Date: Fri, 1 Aug 2025 21:28:17 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Michael Chan <michael.chan@...adcom.com>,
 Pavan Chebbi <pavan.chebbi@...adcom.com>, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, intel-wired-lan@...ts.osuosl.org,
 Donald Hunter <donald.hunter@...il.com>, Carolina Jubran
 <cjubran@...dia.com>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org
Subject: Re: [RFC PATCH v2] ethtool: add FEC bins histogramm report

On 01/08/2025 21:06, Jakub Kicinski wrote:
> On Thu, 31 Jul 2025 16:10:19 -0700 Vadim Fedorenko wrote:
>> - remove sentinel (-1, -1) and use (0, 0) as common array break.
>>    bin (0, 0) is still possible but only as a first element of
>>    ranges array
> 
> I don't see this change in the diff? It's still -1,-1
> 
> Also, not seeing per-lane support here.

My bad, didn't commit after testing :(
I'll wait 24h and submit v3...


>> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
>> index 1063d5d32fea2..69779b51f1dfd 100644
>> --- a/Documentation/netlink/specs/ethtool.yaml
>> +++ b/Documentation/netlink/specs/ethtool.yaml
>> @@ -1239,6 +1239,30 @@ attribute-sets:
>>           name: corr-bits
>>           type: binary
>>           sub-type: u64
>> +      -
>> +        name: hist
>> +        type: nest
>> +        multi-attr: True
>> +        nested-attributes: fec-hist
>> +      -
>> +        name: fec-hist-bin-low
>> +        type: uint
>> +      -
>> +        name: fec-hist-bin-high
>> +        type: uint
> 
> The bounds can be u32, TBH. The value really is a u16 but we don't want
> to waste space on padding in Netlink. Still, no need to go all the way
> to uint.

Got it

>> +        name: fec-hist-bin-val
>> +        type: uint