netdev - Re: [PATCH ipsec v2 2/3] xfrm: bring back device check in validate_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1244baffb21cdb109bb480ceaf535a5cc97f2b3.camel@nvidia.com>
Date: Mon, 4 Aug 2025 09:41:36 +0000
From: Cosmin Ratiu <cratiu@...dia.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "sd@...asysnail.net"
	<sd@...asysnail.net>
CC: Leon Romanovsky <leonro@...dia.com>, "razor@...ckwall.org"
	<razor@...ckwall.org>, "steffen.klassert@...unet.com"
	<steffen.klassert@...unet.com>
Subject: Re: [PATCH ipsec v2 2/3] xfrm: bring back device check in
 validate_xmit_xfrm

On Mon, 2025-08-04 at 11:26 +0200, Sabrina Dubroca wrote:
> This is partial revert of commit
> d53dda291bbd993a29b84d358d282076e3d01506.
> 
> This change causes traffic using GSO with SW crypto running through a
> NIC capable of HW offload to no longer get segmented during
> validate_xmit_xfrm, and is unrelated to the bonding use case
> mentioned
> in the commit.
> 
> Fixes: d53dda291bbd ("xfrm: Remove unneeded device check from
> validate_xmit_xfrm")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> ---
> v2: only revert the unwanted changes
> 
>  net/xfrm/xfrm_device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
> index 1f88472aaac0..c7a1f080d2de 100644
> --- a/net/xfrm/xfrm_device.c
> +++ b/net/xfrm/xfrm_device.c
> @@ -155,7 +155,8 @@ struct sk_buff *validate_xmit_xfrm(struct sk_buff
> *skb, netdev_features_t featur
>  		return skb;
>  	}
>  
> -	if (skb_is_gso(skb) &&
> unlikely(xmit_xfrm_check_overflow(skb))) {
> +	if (skb_is_gso(skb) && (unlikely(x->xso.dev != dev) ||
> +				unlikely(xmit_xfrm_check_overflow(sk
> b)))) {
>  		struct sk_buff *segs;
>  
>  		/* Packet got rerouted, fixup features and segment
> it. */

Thanks!
Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>