netdev - Re: [PATCH net v3] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0e09d1c68582806f5dd693b0c23a4725835e900b.camel@inf.elte.hu>
Date: Mon, 04 Aug 2025 14:32:07 +0200
From: Fejes Ferenc <fejes@....elte.hu>
To: Jakub Kicinski <kuba@...nel.org>, "davem@...emloft.net"
	 <davem@...emloft.net>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "edumazet@...gle.com"
	 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, 
 "andrew+netdev@...n.ch"	 <andrew+netdev@...n.ch>, "horms@...nel.org"
 <horms@...nel.org>, Maher Azzouzi	 <maherazz04@...il.com>,
 "jhs@...atatu.com" <jhs@...atatu.com>,  "xiyou.wangcong@...il.com"	
 <xiyou.wangcong@...il.com>, "jiri@...nulli.us" <jiri@...nulli.us>, 
 "vladimir.oltean@....com"	 <vladimir.oltean@....com>
Subject: Re: [PATCH net v3] net/sched: mqprio: fix stack out-of-bounds write
 in tc entry parsing

On Sat, 2025-08-02 at 00:18 +0000, Jakub Kicinski wrote:
> From: Maher Azzouzi <maherazz04@...il.com>
> 
> TCA_MQPRIO_TC_ENTRY_INDEX is validated using
> NLA_POLICY_MAX(NLA_U32, TC_QOPT_MAX_QUEUE), which allows the value
> TC_QOPT_MAX_QUEUE (16). This leads to a 4-byte out-of-bounds stack
> write in the fp[] array, which only has room for 16 elements (0–15).
> 
> Fix this by changing the policy to allow only up to TC_QOPT_MAX_QUEUE - 1.
> 
> Fixes: f62af20bed2d ("net/sched: mqprio: allow per-TC user input of FP
> adminStatus")
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Maher Azzouzi <maherazz04@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

LGTM!

Reviewed-by: Ferenc Fejes <fejes@....elte.hu>