netdev - Re: [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805195249.GB61519@horms.kernel.org>
Date: Tue, 5 Aug 2025 20:52:49 +0100
From: Simon Horman <horms@...nel.org>
To: David Hill <dhill@...hat.com>
Cc: netdev@...r.kernel.org, anthony.l.nguyen@...el.com,
	przemyslaw.kitszel@...el.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com
Subject: Re: [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit

On Tue, Aug 05, 2025 at 09:40:42AM -0400, David Hill wrote:
> When a VF reaches the limit introduced in this commit [1], the driver
> refuses to add any more MACs to the filter which changes the behavior
> from previous releases and might break some NFVs which sometimes add
> more VFs than the hardcoded limit of 18 and variable limit depending
> on the number of VFs created on a given PF.   Disabling limit_mac_per_vf
> would revert to previous behavior.
> 
> [1] commit cfb1d572c986 ("i40e: Add ensurance of MacVlan resources for every
> trusted VF")
> 
> Signed-off-by: David Hill <dhill@...hat.com>

Hi David,

Unfortunately adding new module parameters to Ethernet drivers is discouraged.
I would suggest that devlink is an appropriate mechanism.

-- 
pw-bot: changes-requested