netdev - Re: [RFC v1 21/22] net: parametrise mp open with a queue config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250805154355.3fc1b57a@kernel.org>
Date: Tue, 5 Aug 2025 15:43:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: netdev@...r.kernel.org, io-uring@...r.kernel.org, Eric Dumazet
 <edumazet@...gle.com>, Willem de Bruijn <willemb@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, andrew+netdev@...n.ch, horms@...nel.org,
 davem@...emloft.net, sdf@...ichev.me, almasrymina@...gle.com,
 dw@...idwei.uk, michael.chan@...adcom.com, dtatulea@...dia.com,
 ap420073@...il.com
Subject: Re: [RFC v1 21/22] net: parametrise mp open with a queue config

On Mon, 4 Aug 2025 13:50:08 +0100 Pavel Begunkov wrote:
> > Since we don't allow MP to be replaced atomically today, we don't
> > actually have to place the mp overrides in the config struct and
> > involve the whole netdev_reconfig_start() _swap() _free() machinery.
> > We can just stash the config in the queue state, and "logically"
> > do what I described above.  
> 
> I was thinking stashing it in struct pp_memory_provider_params and
> applying in netdev_rx_queue_restart(). Let me try to move it
> into __netdev_queue_config. Any preference between keeping just
> the size vs a qcfg pointer in pp_memory_provider_params?
> 
> struct struct pp_memory_provider_params {
> 	const struct memory_provider_ops *mp_ops;
> 	u32 rx_buf_len;
> };
> 
> vs
> 
> struct struct pp_memory_provider_params {
> 	const struct memory_provider_ops *mp_ops;
> 	// providers will need to allocate and keep the qcfg
> 	// until it's completely detached from the queues.
> 	struct netdev_queue_config *qcfg;
> };
> 
> The former one would be simpler for now.

+1, I'd stick to the former. We can adjust later if need be.