netdev - Re: [PATCH net] eth: fbnic: remove the debugging trick of super high page bias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175443601438.2197607.222527424846735387.git-patchwork-notify@kernel.org>
Date: Tue, 05 Aug 2025 23:20:14 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 alexanderduyck@...com
Subject: Re: [PATCH net] eth: fbnic: remove the debugging trick of super high
 page
 bias

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri,  1 Aug 2025 10:07:54 -0700 you wrote:
> Alex added page bias of LONG_MAX, which is admittedly quite
> a clever way of catching overflows of the pp ref count.
> The page pool code was "optimized" to leave the ref at 1
> for freed pages so it can't catch basic bugs by itself any more.
> (Something we should probably address under DEBUG_NET...)
> 
> Unfortunately for fbnic since commit f7dc3248dcfb ("skbuff: Optimization
> of SKB coalescing for page pool") core _may_ actually take two extra
> pp refcounts, if one of them is returned before driver gives up the bias
> the ret < 0 check in page_pool_unref_netmem() will trigger.
> 
> [...]

Here is the summary with links:
  - [net] eth: fbnic: remove the debugging trick of super high page bias
    https://git.kernel.org/netdev/net/c/e407fceeaf1b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html