netdev - Re: [PATCH] eth: mlx4: Fix IS_ERR() vs NULL check bug in mlx4_en_create_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7fe7a7ad-4e32-4435-a93d-0f3b182ef90b@gmail.com>
Date: Wed, 6 Aug 2025 11:00:04 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Miaoqian Lin <linmq006@...il.com>
Cc: Tariq Toukan <tariqt@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eth: mlx4: Fix IS_ERR() vs NULL check bug in
 mlx4_en_create_rx_ring



On 06/08/2025 2:09, Jakub Kicinski wrote:
> On Tue,  5 Aug 2025 06:50:57 +0400 Miaoqian Lin wrote:
>>   	ring->pp = page_pool_create(&pp);
>> -	if (!ring->pp)
>> +	if (IS_ERR(ring->pp))
>>   		goto err_ring;
> 
> Thanks for fixing! Looks we previously depended on err being initialized
> to -ENOMEM, but since we have an errno now, I think it'd be better to
> use it:
> 
> 	if (IS_ERR(ring->pp)) {
> 		err = PTR_ERR(ring->pp);
> 		goto err_ring;
> 	}
> 

+1