netdev - Re: [PATCH v17 03/22] cxl: Move pci generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f064072b-f3d6-47cd-ae05-c8438486f710@amd.com>
Date: Wed, 6 Aug 2025 10:31:05 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: dan.j.williams@...el.com, alejandro.lucero-palau@....com,
 linux-cxl@...r.kernel.org, netdev@...r.kernel.org, edward.cree@....com,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 edumazet@...gle.com, dave.jiang@...el.com
Cc: Ben Cheatham <benjamin.cheatham@....com>, Fan Ni <fan.ni@...sung.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v17 03/22] cxl: Move pci generic code


On 8/6/25 09:46, Alejandro Lucero Palau wrote:
>
> On 7/25/25 23:41, dan.j.williams@...el.com wrote:
>> alejandro.lucero-palau@ wrote:
>>> From: Alejandro Lucero <alucerop@....com>
>>>
>>> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
>>> meanwhile cxl/pci.c implements the functionality for a Type3 device
>>> initialization.
>>>
>>> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
>>> exported and shared with CXL Type2 device initialization.
>>>
>>> Fix cxl mock tests affected by the code move.
>> Next time would be nice to have a bit more color commentary on "fixes".
>> In this case the code was just deleted to address a compilation problem,
>> but that deletion is ok because this function stopped being called back
>> in commit 733b57f262b0 ("cxl/pci: Early setup RCH dport component
>> registers from RCRB").
>
>
> Thanks. I'll add this.
>
>>
>>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>> Reviewed-by: Ben Cheatham <benjamin.cheatham@....com>
>>> Reviewed-by: Fan Ni <fan.ni@...sung.com>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
>>> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
>> Reviewed-by still stands, but I question why is_cxl_restricted() needs
>> to be promoted to a global scope function. Are there going to be RCD
>> type-2 devices that will have Linux drivers?
>
>
> This was necessary in previous versions where a new accel API function 
> required it. It is now gone, so it can be defined as before.
>
> I'll fix it.
>

It turns out this is not the only reason. After moving 
cxl_pci_setup_regs such a definition is needed in two files, so it needs 
to be in a header, but not in include/cxl, so I'll put it in 
drivers/cxl/cxlpci.h



>
> Thanks!
>