netdev - Re: [RFC net-next 01/17] net/smc: Remove __init marker from smc_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1a8b08a-680b-4cd6-a0b2-c94388304fe1@linux.ibm.com>
Date: Thu, 7 Aug 2025 09:01:43 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: dust.li@...ux.alibaba.com, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "D. Wythe" <alibuda@...ux.alibaba.com>,
        Sidraya Jayagond <sidraya@...ux.ibm.com>,
        Wenjia Zhang
 <wenjia@...ux.ibm.com>,
        Julian Ruess <julianr@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Simon Horman <horms@...nel.org>,
        Mahanta Jambigi <mjambigi@...ux.ibm.com>,
        Tony Lu
 <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>,
        Halil Pasic <pasic@...ux.ibm.com>, linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 01/17] net/smc: Remove __init marker from
 smc_core_init()



On 07.08.25 05:34, Dust Li wrote:
> On 2025-08-06 17:41:06, Alexandra Winter wrote:
>> Remove the __init marker because smc_core_init() is not the
>> init function of the smc module and for consistency with
>> smc_core_exit() which neither has an __exit marker.
> Have you seen a real warning or error because of the __init marker ?
> 
> I think the __init marker is just to tell the kernel this function
> will only be called during initialization. So it doesn't need to
> be the module's init function.
> 
> Best regards,
> Dust

My bad. Thank you Dust, for pointing this out.
This patch will be removed from the series.