netdev - Re: [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJSjgW9Ln-waN_oF@calendula>
Date: Thu, 7 Aug 2025 15:00:49 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Julian Anastasov <ja@....bg>
Cc: Frederic Weisbecker <frederic@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...ge.net.au>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jozsef Kadlecsik <kadlec@...filter.org>, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org
Subject: Re: [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity

On Wed, Jul 30, 2025 at 01:28:16PM +0300, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Tue, 29 Jul 2025, Frederic Weisbecker wrote:
> 
> > The estimator kthreads' affinity are defined by sysctl overwritten
> > preferences and applied through a plain call to the scheduler's affinity
> > API.
> > 
> > However since the introduction of managed kthreads preferred affinity,
> > such a practice shortcuts the kthreads core code which eventually
> > overwrites the target to the default unbound affinity.
> > 
> > Fix this with using the appropriate kthread's API.
> > 
> > Fixes: d1a89197589c ("kthread: Default affine kthread to its preferred NUMA node")
> > Signed-off-by: Frederic Weisbecker <frederic@...nel.org>
> 
> 	Looks good to me for the nf tree, thanks!
> 
> Acked-by: Julian Anastasov <ja@....bg>

For the record: Apologies, I will include this patch in the next pull request.