netdev - Re: [RFC net-next 08/17] net/dibs: Register ism as dibs device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250807181934.GM61519@horms.kernel.org>
Date: Thu, 7 Aug 2025 19:19:34 +0100
From: Simon Horman <horms@...nel.org>
To: Alexandra Winter <wintera@...ux.ibm.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Dust Li <dust.li@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Julian Ruess <julianr@...ux.ibm.com>, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Mahanta Jambigi <mjambigi@...ux.ibm.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>, Halil Pasic <pasic@...ux.ibm.com>,
	linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 08/17] net/dibs: Register ism as dibs device

On Thu, Aug 07, 2025 at 05:37:00PM +0100, Simon Horman wrote:
> On Wed, Aug 06, 2025 at 05:41:13PM +0200, Alexandra Winter wrote:
> > Register ism devices with the dibs layer. Follow-on patches will move
> > functionality to the dibs layer.
> > 
> > As DIBS is only a shim layer without any dependencies, we can depend ISM
> > on DIBS without adding indirect dependencies. A follow-on patch will
> > remove implication of SMC by ISM.
> > 
> > Define struct dibs_dev. Follow-on patches will move more content into
> > dibs_dev.  The goal of follow-on patches is that ism_dev will only
> > contain fields that are special for this device driver. The same concept
> > will apply to other dibs device drivers.
> > 
> > Define dibs_dev_alloc(), dibs_dev_add() and dibs_dev_del() to be called
> > by dibs device drivers and call them from ism_drv.c
> > Use ism_dev.dibs for a pointer to dibs_dev.
> > 
> > Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
> 
> ...
> 
> > diff --git a/net/dibs/dibs_main.c b/net/dibs/dibs_main.c
> 
> ...
> 
> > @@ -56,6 +65,33 @@ int dibs_unregister_client(struct dibs_client *client)
> >  }
> >  EXPORT_SYMBOL_GPL(dibs_unregister_client);
> >  
> > +struct dibs_dev *dibs_dev_alloc(void)
> > +{
> > +	struct dibs_dev *dibs;
> > +
> > +	dibs = kzalloc(sizeof(*dibs), GFP_KERNEL);
> 
> Hi Alexandra,
> 
> It is not the case for x86_64, arm64, or s390 (at least).
> But for x86_32 and arm (at least) it seems that linux/slab.h should
> be included in order for kzalloc to be available for compilation.

Similarly for dibs_loopback.c in the following patch.