netdev - Re: [PATCH v4 01/14] net: ionic: Create an auxiliary device for rdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a5b8931-6f0e-497f-aea9-e1c77bfed027@wanadoo.fr>
Date: Sat, 9 Aug 2025 12:58:04 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Abhijit Gangurde <abhijit.gangurde@....com>
Cc: allen.hubbe@....com, nikhil.agarwal@....com, davem@...emloft.net,
 linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 shannon.nelson@....com, brett.creeley@....com, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, corbet@....net, jgg@...pe.ca,
 leon@...nel.org, andrew+netdev@...n.ch
Subject: Re: [PATCH v4 01/14] net: ionic: Create an auxiliary device for rdma
 driver

Le 06/08/2025 à 10:14, Abhijit Gangurde a écrit :
> 
> On 8/2/25 02:45, Christophe JAILLET wrote:
>> Le 23/07/2025 à 19:31, Abhijit Gangurde a écrit :
>>> To support RDMA capable ethernet device, create an auxiliary device in
>>> the ionic Ethernet driver. The RDMA device is modeled as an auxiliary
>>> device to the Ethernet device.
>>
>> ...
>>
>>> +static DEFINE_IDA(aux_ida);
>>> +
>>> +static void ionic_auxbus_release(struct device *dev)
>>> +{
>>> +    struct ionic_aux_dev *ionic_adev;
>>> +
>>> +    ionic_adev = container_of(dev, struct ionic_aux_dev, adev.dev);
>>> +    kfree(ionic_adev);
>>> +}
>>> +
>>> +int ionic_auxbus_register(struct ionic_lif *lif)
>>
>> The 2 places that uses thus function don't check its error code.
> 
> For the eth driver, RDMA functionality is optional hence return code was 
> missed. Although devlink parameter to control this is not included in 
> this series, where it needs return value from this function. Till that 
> point, I'll make it return void.

Don't bother with it.
If it is planned to be used later, I think it is fine to leave it as-is. 
This will save you some work.

Just ignore my comment.

CJ