netdev - Re: [RFC net-next 05/17] net/smc: Improve log message for devices w/o pnetid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJinqObGQ-OHjadu@linux.alibaba.com>
Date: Sun, 10 Aug 2025 22:07:36 +0800
From: Dust Li <dust.li@...ux.alibaba.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Julian Ruess <julianr@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Simon Horman <horms@...nel.org>,
	Mahanta Jambigi <mjambigi@...ux.ibm.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>, Halil Pasic <pasic@...ux.ibm.com>,
	linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 05/17] net/smc: Improve log message for devices
 w/o pnetid

On 2025-08-06 17:41:10, Alexandra Winter wrote:
>Explicitly state in the log message, when a device has no pnetid.
>"with pnetid" and "has pnetid" was misleading for devices without pnetid.
>
>Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>

Reviewed-by: Dust Li <dust.li@...ux.alibaba.com>

This patch doesn't seem strongly related to this patchset, so it might
be better to send this patch separately.

Best regards,
Dust

>---
> net/smc/smc_ib.c  | 18 +++++++++++-------
> net/smc/smc_ism.c | 13 +++++++++----
> 2 files changed, 20 insertions(+), 11 deletions(-)
>
>diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c
>index 53828833a3f7..f2de12990b5b 100644
>--- a/net/smc/smc_ib.c
>+++ b/net/smc/smc_ib.c
>@@ -971,13 +971,17 @@ static int smc_ib_add_dev(struct ib_device *ibdev)
> 					   smcibdev->pnetid[i]))
> 			smc_pnetid_by_table_ib(smcibdev, i + 1);
> 		smc_copy_netdev_ifindex(smcibdev, i);
>-		pr_warn_ratelimited("smc:    ib device %s port %d has pnetid "
>-				    "%.16s%s\n",
>-				    smcibdev->ibdev->name, i + 1,
>-				    smcibdev->pnetid[i],
>-				    smcibdev->pnetid_by_user[i] ?
>-				     " (user defined)" :
>-				     "");
>+		if (smc_pnet_is_pnetid_set(smcibdev->pnetid[i]))
>+			pr_warn_ratelimited("smc:    ib device %s port %d has pnetid %.16s%s\n",
>+					    smcibdev->ibdev->name, i + 1,
>+					    smcibdev->pnetid[i],
>+					    smcibdev->pnetid_by_user[i] ?
>+						" (user defined)" :
>+						"");
>+		else
>+			pr_warn_ratelimited("smc:    ib device %s port %d has no pnetid\n",
>+					    smcibdev->ibdev->name, i + 1);
>+
> 	}
> 	schedule_work(&smcibdev->port_event_work);
> 	return 0;
>diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
>index 7363f8be9f94..503a9f93b392 100644
>--- a/net/smc/smc_ism.c
>+++ b/net/smc/smc_ism.c
>@@ -515,10 +515,15 @@ static void smcd_register_dev(struct ism_dev *ism)
> 	}
> 	mutex_unlock(&smcd_dev_list.mutex);
> 
>-	pr_warn_ratelimited("smc: adding smcd device %s with pnetid %.16s%s\n",
>-			    dev_name(&ism->dev), smcd->pnetid,
>-			    smcd->pnetid_by_user ? " (user defined)" : "");
>-
>+	if (smc_pnet_is_pnetid_set(smcd->pnetid))
>+		pr_warn_ratelimited("smc: adding smcd device %s with pnetid %.16s%s\n",
>+				    dev_name(&ism->dev), smcd->pnetid,
>+				    smcd->pnetid_by_user ?
>+					" (user defined)" :
>+					"");
>+	else
>+		pr_warn_ratelimited("smc: adding smcd device %s without pnetid\n",
>+				    dev_name(&ism->dev));
> 	return;
> }
> 
>-- 
>2.48.1