netdev - Re: [PATCH net v2 1/3] selftests: drv-net: don't assume device has only 2 queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJf9jMgcA42sAcCu@MacBook-Air.local>
Date: Sat, 9 Aug 2025 19:01:48 -0700
From: Joe Damato <joe@...a.to>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	willemdebruijn.kernel@...il.com, skhawaja@...gle.com,
	sdf@...ichev.me, shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net v2 1/3] selftests: drv-net: don't assume device has
 only 2 queues

On Fri, Aug 08, 2025 at 05:12:03PM -0700, Jakub Kicinski wrote:
> The test is implicitly assuming the device only has 2 queues.
> A real device will likely have more. The exact problem is that
> because NAPIs get added to the list from the head, the netlink
> dump reports them in reverse order. So the naive napis[0] will
> actually likely give us the _last_ NAPI, not the first one.
> Re-enable all the NAPIs instead of hard-coding 2 in the test.
> This way the NAPIs we operated on will always reappear,
> doesn't matter where they were in the registration order.
> 
> Fixes: e6d76268813d ("net: Update threaded state in napi config in netif_set_threaded")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  tools/testing/selftests/drivers/net/napi_threaded.py | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Reviewed-by: Joe Damato <joe@...a.to>