netdev - [PATCH 0/6] can: esd_usb: Fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250811210611.3233202-1-stefan.maetje@esd.eu>
Date: Mon, 11 Aug 2025 23:06:05 +0200
From: Stefan Mätje <stefan.maetje@....eu>
To: Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Frank Jungclaus <frank.jungclaus@....eu>,
	linux-can@...r.kernel.org,
	socketcan@....eu
Cc: Simon Horman <horms@...nel.org>,
	Olivier Sobrie <olivier@...rie.be>,
	Oliver Hartkopp <socketcan@...tkopp.net>,
	netdev@...r.kernel.org
Subject: [PATCH 0/6] can: esd_usb: Fixes and improvements

The second patch fixes a condition where the esd_usb CAN driver
may not detect connected CAN-USB devices correctly after a
reboot. This patch was already presented on the list and changes
due to that feedback are integrated.

References:
https://lore.kernel.org/linux-can/d7fd564775351ea8a60a6ada83a0368a99ea6b19.camel@esd.eu/#r

The first patch is only a prerequisite for the second one that
simply avoids calling kfree() with NULL pointers.

The third patch fixes situations where the the handling of TX
context objects for each sent CAN frame could go out of sync
with the acknowledged or erroneous TX jobs and then lose free
TX context objects. This could lead to the driver incapable of
sending frames.

The forth patch adds TX FIFO watermark to eliminate occasional
error messages and significantly reduce the number of calls to
netif_start_queue() and netif_stop_queue().

The fifth patch makes some error messages also print the error
code to achieve a higher significance. Removes also a duplicate
message and makes the register / unregister messages symmetric.

The sixth patch avoids confusing error messages when
disconnecting CAN-USB devices.

Stefan Mätje (6):
  can: esd_usb: Fix possible calls to kfree() with NULL
  can: esd_usb: Fix not detecting version reply in probe routine
  can: esd_usb: Fix handling of TX context objects
  can: esd_usb: Add watermark handling for TX jobs
  can: esd_usb: Rework display of error messages
  can: esd_usb: Avoid errors triggered from USB disconnect

 drivers/net/can/usb/esd_usb.c | 213 +++++++++++++++++++++++++---------
 1 file changed, 156 insertions(+), 57 deletions(-)

base-commit: 0e6639c8505d70e821bc27f951a0ff6303f10d4d
-- 
2.34.1