netdev - Re: [PATCH net-next] bnxt: fill data page pool with frags if PAGE_SIZE > BNXT_RX_PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLimab-kzux20TU4GD72GCa7PSe=JTxaeErDRe+zHke7TGQ@mail.gmail.com>
Date: Mon, 11 Aug 2025 14:07:52 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Pavan Chebbi <pavan.chebbi@...adcom.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] bnxt: fill data page pool with frags if
 PAGE_SIZE > BNXT_RX_PAGE_SIZE

On Mon, Aug 11, 2025 at 1:19 PM David Wei <dw@...idwei.uk> wrote:
>
> On 2025-08-11 11:08, Michael Chan wrote:
> > On Mon, Aug 11, 2025 at 10:43 AM David Wei <dw@...idwei.uk> wrote:
> >>
> >> The data page pool always fills the HW rx ring with pages. On arm64 with
> >> 64K pages, this will waste _at least_ 32K of memory per entry in the rx
> >> ring.
> >>
> >> Fix by fragmenting the pages if PAGE_SIZE > BNXT_RX_PAGE_SIZE. This
> >> makes the data page pool the same as the header pool.
> >>
> >> Tested with iperf3 with a small (64 entries) rx ring to encourage buffer
> >> circulation.
> >
> > This was a regression when adding devmem support.  Prior to that,
> > __bnxt_alloc_rx_page() would handle this properly.  Should we add a
> > Fixes tag?
>
> Sounds good, how about this?
>
> Fixes: cd1fafe7da1f ("eth: bnxt: add support rx side device memory TCP")

The tag is correct.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)