netdev - Re: [PATCH net v2 1/2] devlink: let driver opt out of automatic phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fee09923-c46c-4c39-8f27-ee720b604e56@intel.com>
Date: Mon, 11 Aug 2025 14:32:28 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<andrew+netdev@...n.ch>, <netdev@...r.kernel.org>, Jedrzej Jagielski
	<jedrzej.jagielski@...el.com>, <przemyslaw.kitszel@...el.com>,
	<jiri@...nulli.us>, <horms@...nel.org>, <David.Kaplan@....com>,
	<dhowells@...hat.com>, Paul Menzel <pmenzel@...gen.mpg.de>
Subject: Re: [PATCH net v2 1/2] devlink: let driver opt out of automatic
 phys_port_name generation



On 8/11/2025 2:27 PM, Tony Nguyen wrote:
> 
> 
> On 8/8/2025 11:53 AM, Jakub Kicinski wrote:
>> On Tue,  5 Aug 2025 15:33:41 -0700 Tony Nguyen wrote:
>>> +	if (devlink_port->attrs.no_phys_port_name)
>>> +		return 0;
>>
>> Why are you returning 0 rather than -EOPNOTSUPP?
>> Driver which doesn't implement phys_port_name would normally return
>> -EOPNOTSUPP when user tries to read the sysfs file.
> 
> Jedrek is out so I'm not sure the reason, but it does seem
> -EOPNOTSUPP would be more appropriate so I'll make that change.
> 
> Thanks,
> Tony

I agree, -EOPNOTSUPP makes the most sense here. It aligns with the way
we return -EOPNOTSUPP when attributes for the port aren't set.


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)