netdev - Re: [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo from system() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJqDDIZxNAnZ-I8W@MacBook-Air.local>
Date: Mon, 11 Aug 2025 16:55:56 -0700
From: Joe Damato <joe@...a.to>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shuah@...nel.org, sdf@...ichev.me, almasrymina@...gle.com,
	noren@...dia.com, linux-kselftest@...r.kernel.org,
	ap420073@...il.com
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo
 from system() calls

On Mon, Aug 11, 2025 at 04:13:31PM -0700, Jakub Kicinski wrote:
> The general expectations for network HW selftests is that they
> will be run as root. sudo doesn't seem to work on NIPA VMs.
> While it's probably something solvable in the setup I think we should
> remove the sudos. devmem is the only networking test using sudo.

FWIW, it looks like:

virtio_net/virtio_net_common.sh

is also using sudo... that said in general I agree on removing the sudos, so:

Reviewed-by: Joe Damato <joe@...a.to>