netdev - Re: [PATCH net-next 3/5] selftests: drv-net: devmem: add / correct the IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJqFrdKEqRj1mI3y@MacBook-Air.local>
Date: Mon, 11 Aug 2025 17:07:09 -0700
From: Joe Damato <joe@...a.to>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shuah@...nel.org, sdf@...ichev.me, almasrymina@...gle.com,
	noren@...dia.com, linux-kselftest@...r.kernel.org,
	ap420073@...il.com
Subject: Re: [PATCH net-next 3/5] selftests: drv-net: devmem: add / correct
 the IPv6 support

On Mon, Aug 11, 2025 at 04:13:32PM -0700, Jakub Kicinski wrote:
> We need to use bracketed IPv6 addresses for socat.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  tools/testing/selftests/drivers/net/hw/devmem.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py
> index baa2f24240ba..0a2533a3d6d6 100755
> --- a/tools/testing/selftests/drivers/net/hw/devmem.py
> +++ b/tools/testing/selftests/drivers/net/hw/devmem.py
> @@ -24,7 +24,7 @@ from lib.py import ksft_disruptive
>      require_devmem(cfg)
>  
>      port = rand_port()
> -    socat = f"socat -u - TCP{cfg.addr_ipver}:{cfg.addr}:{port},bind={cfg.remote_addr}:{port}"
> +    socat = f"socat -u - TCP{cfg.addr_ipver}:{cfg.baddr}:{port},bind={cfg.remote_baddr}:{port}"

FWIW I had no idea socat supports bracketed v4 addresses (just to make sure
this change won't break anything). A quick test I did locally shows it does.

Reviewed-by: Joe Damato <joe@...a.to>