netdev - Re: [PATCH net] net: mctp: Fix bad kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b497e639-7a5c-4bb5-8e5c-54c4aa79fd95@ghiti.fr>
Date: Tue, 12 Aug 2025 09:17:58 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Matt Johnston <matt@...econstruct.com.au>,
 Jeremy Kerr <jk@...econstruct.com.au>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net] net: mctp: Fix bad kfree_skb in bind lookup test

Hi Matt,

On 8/12/25 07:08, Matt Johnston wrote:
> The kunit test's skb_pkt is consumed by mctp_dst_input() so shouldn't be
> freed separately.
>
> Fixes: e6d8e7dbc5a3 ("net: mctp: Add bind lookup test")
> Reported-by: Alexandre Ghiti <alex@...ti.fr>
> Closes: https://lore.kernel.org/all/734b02a3-1941-49df-a0da-ec14310d41e4@ghiti.fr/
> Signed-off-by: Matt Johnston <matt@...econstruct.com.au>
> ---
>   net/mctp/test/route-test.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c
> index fb6b46a952cb432163f6adb40bb395d658745efd..69a3ccfc6310cd78d4138f56609f1d83d4082bd1 100644
> --- a/net/mctp/test/route-test.c
> +++ b/net/mctp/test/route-test.c
> @@ -1586,7 +1586,6 @@ static void mctp_test_bind_lookup(struct kunit *test)
>   
>   cleanup:
>   	kfree_skb(skb_sock);
> -	kfree_skb(skb_pkt);
>   
>   	/* Drop all binds */
>   	for (size_t i = 0; i < ARRAY_SIZE(lookup_binds); i++)
>
> ---
> base-commit: 89886abd073489e26614e4d80fb8eb70d3938a0b
> change-id: 20250812-fix-mctp-bind-test-5a3582643ae4
>
> Best regards,

Can't see any warning/oops anymore this morning with this patch, thanks!

Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks for the quick fix,

Alex