netdev - Re: [PATCH net-next 1/2] sctp: Use HMAC-SHA1 and HMAC-SHA256 library for chunk authentication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167af41d-5d9e-4526-bdc5-0806a4f3cf36@redhat.com>
Date: Tue, 12 Aug 2025 12:58:39 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Biggers <ebiggers@...nel.org>, linux-sctp@...r.kernel.org,
 netdev@...r.kernel.org, Xin Long <lucien.xin@...il.com>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc: linux-crypto@...r.kernel.org, Florian Westphal <fw@...len.de>
Subject: Re: [PATCH net-next 1/2] sctp: Use HMAC-SHA1 and HMAC-SHA256 library
 for chunk authentication

On 8/11/25 9:37 PM, Eric Biggers wrote:
> diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig
> index 24d5a35ce894a..192027555b4d8 100644
> --- a/net/sctp/Kconfig
> +++ b/net/sctp/Kconfig
> @@ -5,13 +5,12 @@
>  
>  menuconfig IP_SCTP
>  	tristate "The SCTP Protocol"
>  	depends on INET
>  	depends on IPV6 || IPV6=n
> -	select CRYPTO
> -	select CRYPTO_HMAC
> -	select CRYPTO_SHA1
> +	select CRYPTO_LIB_SHA1
> +	select CRYPTO_LIB_SHA256
>  	select NET_CRC32C
>  	select NET_UDP_TUNNEL
>  	help
>  	  Stream Control Transmission Protocol
>  

As pinned-out by Florian, the above breaks a few selftests:

https://lore.kernel.org/netdev/aJsaylkoOto0UsTL@strlen.de/T/#m68ce5625633ce065e73cee9e2c13e40772f499c2

could you please add a prereq patch adjusting the self-tests config?

Thanks!

Paolo