netdev - Re: [PATCH net-next v4 1/4] net: ngbe: change the default ITR setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJshSlT+YuSjlz0n@mev-dev.igk.intel.com>
Date: Tue, 12 Aug 2025 13:11:06 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Mengyuan Lou <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v4 1/4] net: ngbe: change the default ITR setting

On Tue, Aug 12, 2025 at 09:50:20AM +0800, Jiawen Wu wrote:
> Change the default RX/TX ITR for wx_mac_em devices from 20K to 7K, which
> is an experience value from out-of-tree ngbe driver, to get higher
> performance on some platforms with weak single-core performance.
> 
> TCP_SRTEAM test on Phytium 2000+ shows that the throughput of 64-Byte
> packets is increased from 350.53Mbits/s to 395.92Mbits/s.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> ---
>  drivers/net/ethernet/wangxun/libwx/wx_ethtool.c | 12 ++++++++----
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c   |  5 ++---
>  2 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> index c12a4cb951f6..d9412e55b5b2 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> @@ -359,10 +359,14 @@ int wx_set_coalesce(struct net_device *netdev,
>  	else
>  		wx->rx_itr_setting = ec->rx_coalesce_usecs;
>  
> -	if (wx->rx_itr_setting == 1)
> -		rx_itr_param = WX_20K_ITR;
> -	else
> +	if (wx->rx_itr_setting == 1) {
> +		if (wx->mac.type == wx_mac_em)
> +			rx_itr_param = WX_7K_ITR;
> +		else
> +			rx_itr_param = WX_20K_ITR;
> +	} else {
>  		rx_itr_param = wx->rx_itr_setting;
> +	}
>  
>  	if (ec->tx_coalesce_usecs > 1)
>  		wx->tx_itr_setting = ec->tx_coalesce_usecs << 2;
> @@ -377,7 +381,7 @@ int wx_set_coalesce(struct net_device *netdev,
>  			tx_itr_param = WX_12K_ITR;
>  			break;
>  		default:
> -			tx_itr_param = WX_20K_ITR;
> +			tx_itr_param = WX_7K_ITR;
>  			break;

You are removing these code in patch 3, maybe just move the patch after
it.

>  		}
>  	} else {
> diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> index e0fc897b0a58..3fff73ae44af 100644
> --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
> @@ -119,9 +119,8 @@ static int ngbe_sw_init(struct wx *wx)
>  						   num_online_cpus());
>  	wx->rss_enabled = true;
>  
> -	/* enable itr by default in dynamic mode */
> -	wx->rx_itr_setting = 1;
> -	wx->tx_itr_setting = 1;
> +	wx->rx_itr_setting = WX_7K_ITR;
> +	wx->tx_itr_setting = WX_7K_ITR;

Seems fine,
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

>  
>  	/* set default ring sizes */
>  	wx->tx_ring_count = NGBE_DEFAULT_TXD;
> -- 
> 2.48.1
>