netdev - Re: [PATCH 1/6] can: esd_usb: Fix possible calls to kfree() with NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee619a2d-a39d-4f48-ba18-07d4d9ef427e@linux.dev>
Date: Tue, 12 Aug 2025 13:33:40 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Stefan Mätje <stefan.maetje@....eu>,
 Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>,
 Frank Jungclaus <frank.jungclaus@....eu>, linux-can@...r.kernel.org,
 socketcan@....eu
Cc: Simon Horman <horms@...nel.org>, Olivier Sobrie <olivier@...rie.be>,
 Oliver Hartkopp <socketcan@...tkopp.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/6] can: esd_usb: Fix possible calls to kfree() with NULL

On 11/08/2025 22:06, Stefan MÃ¤tje wrote:
> In esd_usb_start() kfree() is called with the msg variable even if the
> allocation of *msg failed.

But kfree() works fine with NULL pointers, have you seen any real issues
with this code?