netdev - Re: [PATCH net-next 1/2] devlink/port: Check attributes early and constify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bf50cb2-31c6-4391-a09e-a73fd84fe051@linux.dev>
Date: Tue, 12 Aug 2025 13:56:57 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Parav Pandit <parav@...dia.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 netdev@...r.kernel.org
Cc: jiri@...nulli.us, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 1/2] devlink/port: Check attributes early and
 constify

On 12/08/2025 04:51, Parav Pandit wrote:
> Constify the devlink port attributes to indicate they are read only
> and does not depend on anything else. Therefore, validate it early
> before setting in the devlink port.
> 
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Parav Pandit <parav@...dia.com>
> ---
>   include/net/devlink.h | 2 +-
>   net/devlink/port.c    | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index 93640a29427c..c6f3afa92c8f 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -1739,7 +1739,7 @@ void devlink_port_type_ib_set(struct devlink_port *devlink_port,
>   			      struct ib_device *ibdev);
>   void devlink_port_type_clear(struct devlink_port *devlink_port);
>   void devlink_port_attrs_set(struct devlink_port *devlink_port,
> -			    struct devlink_port_attrs *devlink_port_attrs);
> +			    const struct devlink_port_attrs *dl_port_attrs);
>   void devlink_port_attrs_pci_pf_set(struct devlink_port *devlink_port, u32 controller,
>   				   u16 pf, bool external);
>   void devlink_port_attrs_pci_vf_set(struct devlink_port *devlink_port, u32 controller,
> diff --git a/net/devlink/port.c b/net/devlink/port.c
> index 939081a0e615..1033b9ad2af4 100644
> --- a/net/devlink/port.c
> +++ b/net/devlink/port.c
> @@ -1357,17 +1357,17 @@ static int __devlink_port_attrs_set(struct devlink_port *devlink_port,
>    *	@attrs: devlink port attrs
>    */
>   void devlink_port_attrs_set(struct devlink_port *devlink_port,
> -			    struct devlink_port_attrs *attrs)
> +			    const struct devlink_port_attrs *attrs)
>   {
>   	int ret;
>   
>   	ASSERT_DEVLINK_PORT_NOT_REGISTERED(devlink_port);
> +	WARN_ON(attrs->splittable && attrs->split);
>   
>   	devlink_port->attrs = *attrs;
>   	ret = __devlink_port_attrs_set(devlink_port, attrs->flavour);
>   	if (ret)
>   		return;
> -	WARN_ON(attrs->splittable && attrs->split);

After this change there is no need for local variable and the "if" block

>   }
>   EXPORT_SYMBOL_GPL(devlink_port_attrs_set);
>