netdev - Re: [PATCH net] selftests: drv-net: wait for carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250812071600.6714433d@kernel.org>
Date: Tue, 12 Aug 2025 07:16:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Paolo Abeni <pabeni@...hat.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org,
 willemb@...gle.com, petrm@...dia.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net] selftests: drv-net: wait for carrier

On Tue, 12 Aug 2025 13:12:47 +0200 Paolo Abeni wrote:
> On 8/9/25 12:57 AM, Jakub Kicinski wrote:
> > @@ -48,6 +51,19 @@ from .remote import Remote
> >                  env[pair[0]] = pair[1]
> >          return ksft_setup(env)
> >  
> > +    def __enter__(self):
> > +        ip(f"link set dev {self.dev['ifname']} up")
> > +        wait_file(f"/sys/class/net/{self.dev['ifname']}/carrier",
> > +                  lambda x: x.strip() == "1")
> > +
> > +        return self
> > +
> > +    def __exit__(self, ex_type, ex_value, ex_tb):
> > +        """
> > +        __exit__ gets called at the end of a "with" block.
> > +        """
> > +        self.__del__()
> > +  
> 
> pylint is doing what looks like a reasonable complain to me:
> 
> tools/testing/selftests/drivers/net/lib/py/env.py:65:8: E1101: Instance
> of 'NetDrvEnvBase' has no '__del__' member (no-member)

I know, it's an abstract class. The point of having an empty method is
lost on me. But okay, let me obey the static analyzer overlord.