netdev - Re: [PATCH net] net: explicitly check in of_phy_is_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250812150657.mwsnor327tepkplr@skbuf>
Date: Tue, 12 Aug 2025 18:06:57 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Stas Sergeev <stsp@...t.ru>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: explicitly check in of_phy_is_fixed_link() for
 managed = "in-band-status"

On Tue, Aug 12, 2025 at 12:33:36PM +0100, Russell King (Oracle) wrote:
> As an additional point, I'm not sure what has broken that justifies
> this change for the net tree. You mention at one point in the commit
> description about wanting to use "c73" as a string for "managed",
> which suggests new development, and thus shouldn't this be targetting
> net-next?
> 
> Note that at present, all dts files in the kernel either omit the
> managed property, or have it present with value "in-band-status".
> 
> Thus, I think the commit makes sense for net-next.

Correct, thanks for challenging this, nothing seems to be broken if
stable kernels are left alone in their thinking that managed = "c73"
would be a fixed link. It was out of caution that old and new kernels
would disagree on this when faced with the same device tree, but it does
not seem to matter. I will re-target the patch to net-next.