netdev - Re: [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo from system() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izPOYNyj7v9ZaVC1Z_+pZhHGjCLjFCK+55i_zk-VPrP2Tw@mail.gmail.com>
Date: Tue, 12 Aug 2025 09:58:28 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>, Pranjal Shrivastava <praan@...gle.com>, 
	Shivaji Kant <shivajikant@...gle.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org, 
	sdf@...ichev.me, noren@...dia.com, linux-kselftest@...r.kernel.org, 
	ap420073@...il.com
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo from
 system() calls

On Mon, Aug 11, 2025 at 4:13 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> The general expectations for network HW selftests is that they
> will be run as root. sudo doesn't seem to work on NIPA VMs.
> While it's probably something solvable in the setup I think we should
> remove the sudos. devmem is the only networking test using sudo.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

I suspect this breaks my test setup, but I can probably figure out how
to run our tests as sudo. I can't argue with consistency with the rest
of the tests which don't sudo anyway :D

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

-- 
Thanks,
Mina