netdev - Re: [PATCH net-next v2] selftests: drv-net: wait for carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJuACzIZcknUq6C8@MacBook-Air.local>
Date: Tue, 12 Aug 2025 10:55:23 -0700
From: Joe Damato <joe@...a.to>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shuah@...nel.org, willemb@...gle.com, petrm@...dia.com,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2] selftests: drv-net: wait for carrier

On Tue, Aug 12, 2025 at 07:20:54AM -0700, Jakub Kicinski wrote:
> On fast machines the tests run in quick succession so even
> when tests clean up after themselves the carrier may need
> some time to come back.
> 
> Specifically in NIPA when ping.py runs right after netpoll_basic.py
> the first ping command fails.
> 
> Since the context manager callbacks are now common NetDrvEpEnv
> gets an ip link up call as well.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2:
>  - add an empty __del__
> v1: https://lore.kernel.org/20250808225741.1095702-1-kuba@kernel.org
> 
> CC: shuah@...nel.org
> CC: willemb@...gle.com
> CC: petrm@...dia.com
> CC: linux-kselftest@...r.kernel.org
> ---
>  .../selftests/drivers/net/lib/py/__init__.py  |  2 +-
>  .../selftests/drivers/net/lib/py/env.py       | 41 +++++++++----------
>  tools/testing/selftests/net/lib/py/utils.py   | 18 ++++++++
>  3 files changed, 39 insertions(+), 22 deletions(-)

Reviewed-by: Joe Damato <joe@...a.to>