netdev - Re: [PATCH net-next 5/5] selftests: drv-net: devmem: flip the direction of Tx tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izP-EMxFFSF1f_8ceP2_1vt-Jrn0tnp-Bc4OKRgX3Uz_3A@mail.gmail.com>
Date: Tue, 12 Aug 2025 11:32:09 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>, Shivaji Kant <shivajikant@...gle.com>, 
	Pranjal Shrivastava <praan@...gle.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org, 
	sdf@...ichev.me, noren@...dia.com, linux-kselftest@...r.kernel.org, 
	ap420073@...il.com
Subject: Re: [PATCH net-next 5/5] selftests: drv-net: devmem: flip the
 direction of Tx tests

On Mon, Aug 11, 2025 at 4:13 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> The Device Under Test should always be the local system.
> While the Rx test gets this right the Tx test is sending
> from remote to local. So Tx of DMABUF memory happens on remote.
>
> These tests never run in NIPA since we don't have a compatible
> device so we haven't caught this.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Changes look reasonable, and to my eye the rx and tx commands are just
switched with no changes. I would have liked to test this first but
I'm not sure I'll get the chance today. So:

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

and I guess when I have a chance to test I'll either give Tested-by or
a fix on top.

-- 
Thanks,
Mina