netdev - Re: [Intel-wired-lan] [PATCH 02/12] ice: split queue stuff out of ice_virtchnl.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a551d1c2-1714-4168-b647-b55a9ec8bac9@intel.com>
Date: Wed, 13 Aug 2025 09:38:46 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH 02/12] ice: split queue stuff out of
 ice_virtchnl.c - p2

On 8/12/25 22:07, Paul Menzel wrote:
> Dear Przemek,
> 
> 
> Thank you for your patch.
> 
> Am 12.08.25 um 15:29 schrieb Przemek Kitszel:
>> Add copy of ice_virtchnl.c under the original name/location.
> 
> Why not mention the rename in the summary/title instead of p2?

that was "technical git detail", that is gone after the full series is
applied, anyway, I could apply:
	s/p1/tmp rename/;s/p2/copy back/
(but would rather avoid sending whole series again on IWL just for that)

for "cleanup - pX" commits I would keep title as-is, as those were split
only to avoid git creativity in minimizing the diff

> 
>> Now both ice_virtchnl.c and ice_virtchnl_queues.c have the same content,
>> and only the former of the two in use.
>>
>> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>> ---
>>   drivers/net/ethernet/intel/ice/Makefile       |    2 +-
>>   drivers/net/ethernet/intel/ice/ice_virtchnl.c | 4611 +++++++++++++++++
>>   2 files changed, 4612 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl.c
> 
> […]
> 
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>

thank you!

> 
> 
> Kind regards,
> 
> Paul