netdev - Re: [PATCH net-next] net: phy: mscc: report and configure in-band auto-negotiation for SGMII/QSGMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJxH_SJvte8BpFfa@shell.armlinux.org.uk>
Date: Wed, 13 Aug 2025 09:08:29 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: mscc: report and configure in-band
 auto-negotiation for SGMII/QSGMII

On Wed, Aug 13, 2025 at 10:44:54AM +0300, Vladimir Oltean wrote:
> The following Vitesse/Microsemi/Microchip PHYs, among those supported by
> this driver, have the host interface configurable as SGMII or QSGMII:
> - VSC8504
> - VSC8514
> - VSC8552
> - VSC8562
> - VSC8572
> - VSC8574
> - VSC8575
> - VSC8582
> - VSC8584
> 
> All these PHYs are documented to have bit 7 of "MAC SerDes PCS Control"
> as "MAC SerDes ANEG enable".
> 
> Out of these, I could test the VSC8514 quad PHY in QSGMII. This works
> both with the in-band autoneg on and off, on the NXP LS1028A-RDB and
> T1040-RDB boards.
> 
> Notably, the bit is sticky (survives soft resets), so giving Linux the
> tools to read and modify this settings makes it robust to changes made
> to it by previous boot layers (U-Boot).
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Looks sensible.

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!