netdev - Re: [Intel-wired-lan] [PATCH v2] igb: Fix NULL pointer dereference in ethtool loopback test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF-tjThBebBj3auCam04nMV44j5LNhXnfRKYy6_jjM49wWCOmg@mail.gmail.com>
Date: Wed, 13 Aug 2025 17:23:32 +0800
From: Tianyu Xu <xtydtc@...il.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com, kuba@...nel.org, 
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Tianyu Xu <tianyxu@...co.com>, 
	Aleksandr Loktionov <aleksandr.loktionov@...el.com>, Joe Damato <joe@...a.to>
Subject: Re: [Intel-wired-lan] [PATCH v2] igb: Fix NULL pointer dereference in
 ethtool loopback test

Hi Paul,
On my board with i210 NIC, "ethtool -t eth0" got the NULL pointer dereference.
After the fix, "ethtool -t eth0" works well.

Kind regards,
Tianyu.


Paul Menzel <pmenzel@...gen.mpg.de> 于2025年8月12日周二 22:00写道：
>
> Dear Tianyu,
>
>
> Thank you for your patch.
>
> Am 12.08.25 um 15:10 schrieb Tianyu Xu:
> > The igb driver currently causes a NULL pointer dereference when executing
> > the ethtool loopback test. This occurs because there is no associated
>
> Where is this test located? Or, how do I run the test manually?
>
> > q_vector for the test ring when it is set up, as interrupts are typically
> > not added to the test rings.
> >
> > Since commit 5ef44b3cb43b removed the napi_id assignment in
> > __xdp_rxq_info_reg(), there is no longer a need to pass a napi_id to it.
> > Therefore, simply use 0 as the last parameter.
> >
> > Fixes: 2c6196013f84 ("igb: Add AF_XDP zero-copy Rx support")
> > Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> > Reviewed-by: Joe Damato <joe@...a.to>
> > Signed-off-by: Tianyu Xu <tianyxu@...co.com>
> > ---
> > Thanks to Aleksandr and Joe for your feedback. I have added the Fixes tag
> > and formatted the lines to 75 characters based on your comments.
> >
> >   drivers/net/ethernet/intel/igb/igb_main.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> > index a9a7a94ae..453deb6d1 100644
> > --- a/drivers/net/ethernet/intel/igb/igb_main.c
> > +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> > @@ -4453,8 +4453,7 @@ int igb_setup_rx_resources(struct igb_ring *rx_ring)
> >       if (xdp_rxq_info_is_reg(&rx_ring->xdp_rxq))
> >               xdp_rxq_info_unreg(&rx_ring->xdp_rxq);
> >       res = xdp_rxq_info_reg(&rx_ring->xdp_rxq, rx_ring->netdev,
> > -                            rx_ring->queue_index,
> > -                            rx_ring->q_vector->napi.napi_id);
> > +                            rx_ring->queue_index, 0);
> >       if (res < 0) {
> >               dev_err(dev, "Failed to register xdp_rxq index %u\n",
> >                       rx_ring->queue_index);
>
> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
>
>
> Kind regards,
>
> Paul