| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <B301753EBB777DDB+20250813094914.GB972027@nic-Precision-5820-Tower>
Date: Wed, 13 Aug 2025 17:49:14 +0800
From: Yibo Dong <dong100@...se.com>
To: MD Danish Anwar <danishanwar@...com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
corbet@....net, gur.stavi@...wei.com, maddy@...ux.ibm.com,
mpe@...erman.id.au, lee@...ger.us, gongfan1@...wei.com,
lorenzo@...nel.org, geert+renesas@...der.be,
Parthiban.Veerasooran@...rochip.com, lukas.bulwahn@...hat.com,
alexanderduyck@...com, richardcochran@...il.com,
netdev@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/5] net: rnpgbe: Add register_netdev
On Wed, Aug 13, 2025 at 01:56:07PM +0530, MD Danish Anwar wrote:
> On 12/08/25 3:09 pm, Dong Yibo wrote:
> > Initialize get mac from hw, register the netdev.
> >
> > Signed-off-by: Dong Yibo <dong100@...se.com>
> > ---
> > drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 22 ++++++
> > .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c | 73 ++++++++++++++++++
> > drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h | 1 +
> > .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 76 +++++++++++++++++++
> > 4 files changed, 172 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > index 6cb14b79cbfe..644b8c85c29d 100644
> > --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> > @@ -6,6 +6,7 @@
> >
> > #include <linux/types.h>
> > #include <linux/mutex.h>
> > +#include <linux/netdevice.h>
> >
> > extern const struct rnpgbe_info rnpgbe_n500_info;
> > extern const struct rnpgbe_info rnpgbe_n210_info;
> > @@ -86,6 +87,18 @@ struct mucse_mbx_info {
> > u32 fw2pf_mbox_vec;
> > };
> >
> > +struct mucse_hw_operations {
> > + int (*init_hw)(struct mucse_hw *hw);
> > + int (*reset_hw)(struct mucse_hw *hw);
> > + void (*start_hw)(struct mucse_hw *hw);
> > + void (*init_rx_addrs)(struct mucse_hw *hw);
> > + void (*driver_status)(struct mucse_hw *hw, bool enable, int mode);
> > +};
>
> You define functions init_hw, start_hw, and init_rx_addrs in this
> structure but they aren't implemented in this patch. Either implement
> them or remove them if not needed yet.
>
>
Got it, I will remove not implemented define.
> > +
> > +enum {
> > + mucse_driver_insmod,
> > +};
> > +
> > struct mucse_hw {
> > void *back;
> > u8 pfvfnum;
> > @@ -96,12 +109,18 @@ struct mucse_hw {
> > u32 axi_mhz;
> > u32 bd_uid;
> > enum rnpgbe_hw_type hw_type;
> > + const struct mucse_hw_operations *ops;
> > struct mucse_dma_info dma;
> > struct mucse_eth_info eth;
> > struct mucse_mac_info mac;
> > struct mucse_mbx_info mbx;
> > + u32 flags;
> > +#define M_FLAGS_INIT_MAC_ADDRESS BIT(0)
> > u32 driver_version;
> > u16 usecstocount;
> > + int lane;
> > + u8 addr[ETH_ALEN];
> > + u8 perm_addr[ETH_ALEN];
> > };
> >
> > struct mucse {
> > @@ -123,4 +142,7 @@ struct rnpgbe_info {
> > #define PCI_DEVICE_ID_N500_DUAL_PORT 0x8318
> > #define PCI_DEVICE_ID_N210 0x8208
> > #define PCI_DEVICE_ID_N210L 0x820a
> > +
> > +#define dma_wr32(dma, reg, val) writel((val), (dma)->dma_base_addr + (reg))
> > +#define dma_rd32(dma, reg) readl((dma)->dma_base_addr + (reg))
> > #endif /* _RNPGBE_H */
> > diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
> > index 16d0a76114b5..3eaa0257f3bb 100644
> > --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
> > +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
> > @@ -2,10 +2,82 @@
> > /* Copyright(c) 2020 - 2025 Mucse Corporation. */
> >
> > #include <linux/string.h>
> > +#include <linux/etherdevice.h>
> >
> > #include "rnpgbe.h"
> > #include "rnpgbe_hw.h"
> > #include "rnpgbe_mbx.h"
> > +#include "rnpgbe_mbx_fw.h"
> > +
> > +/**
> > + * rnpgbe_get_permanent_mac - Get permanent mac
> > + * @hw: hw information structure
> > + * @mac_addr: pointer to store mac
> > + *
> > + * rnpgbe_get_permanent_mac tries to get mac from hw.
> > + * It use eth_random_addr if failed.
> > + **/
> > +static void rnpgbe_get_permanent_mac(struct mucse_hw *hw,
> > + u8 *mac_addr)
> > +{
> > + if (mucse_fw_get_macaddr(hw, hw->pfvfnum, mac_addr, hw->lane)) {
> > + eth_random_addr(mac_addr);
> > + } else {
> > + if (!is_valid_ether_addr(mac_addr))
> > + eth_random_addr(mac_addr);
> > + }
> > +
>
> The function should log a warning when falling back to a random MAC
> address, especially in the second case where the hardware returned an
> invalid MAC.
>
Got it, I will fix it.
> > + hw->flags |= M_FLAGS_INIT_MAC_ADDRESS;
> > +}
> > +
>
> > +/**
> > + * rnpgbe_xmit_frame - Send a skb to driver
> > + * @skb: skb structure to be sent
> > + * @netdev: network interface device structure
> > + *
> > + * @return: NETDEV_TX_OK or NETDEV_TX_BUSY
> > + **/
> > +static netdev_tx_t rnpgbe_xmit_frame(struct sk_buff *skb,
> > + struct net_device *netdev)
> > +{
> > + dev_kfree_skb_any(skb);
> > + return NETDEV_TX_OK;
> > +}
>
> Extra indentation on these two lines. Also, the function just drops all
> packets without any actual transmission. This should at least increment
> the drop counter statistics.
>
Got it, I will add 'netdev->stats.tx_dropped++;' here.
> > +
> > +static const struct net_device_ops rnpgbe_netdev_ops = {
> > + .ndo_open = rnpgbe_open,
> > + .ndo_stop = rnpgbe_close,
> > + .ndo_start_xmit = rnpgbe_xmit_frame,
> > +};
>
>
> --
> Thanks and Regards,
> Danish
>
>
Thanks for your feedback.
Powered by blists - more mailing lists