netdev - RE: [PATCH v3 net-next 06/15] ptp: netc: add periodic pulse output support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85108318D1AEB3B4AC615D33882AA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Wed, 13 Aug 2025 01:42:58 +0000
From: Wei Fang <wei.fang@....com>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, Claudiu Manoil
	<claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>, Frank Li
	<frank.li@....com>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, "F.S. Peng" <fushi.peng@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>
Subject: RE: [PATCH v3 net-next 06/15] ptp: netc: add periodic pulse output
 support

> On Tue, Aug 12, 2025 at 05:46:25PM +0800, Wei Fang wrote:
> > @@ -210,77 +343,178 @@ static void netc_timer_set_pps_alarm(struct
> > netc_timer *priv, int channel,  static int netc_timer_enable_pps(struct
> netc_timer *priv,
> >  				 struct ptp_clock_request *rq, int on)  {
> > -	u32 fiper, fiper_ctrl;
> > +	struct device *dev = &priv->pdev->dev;
> >  	unsigned long flags;
> > +	struct netc_pp *pp;
> > +	int err = 0;
> >
> >  	spin_lock_irqsave(&priv->lock, flags);
> >
> > -	fiper_ctrl = netc_timer_rd(priv, NETC_TMR_FIPER_CTRL);
> > -
> >  	if (on) {
> 		...
> >  	} else {
> > -		if (!priv->pps_enabled)
> > +		/* pps_channel is invalid if PPS is not enabled, so no
> > +		 * processing is needed.
> > +		 */
> > +		if (priv->pps_channel >= NETC_TMR_FIPER_NUM)
> >  			goto unlock_spinlock;
> >
> > -		fiper = NETC_TMR_DEFAULT_FIPER;
> > -		priv->tmr_emask &= ~(TMR_TEVNET_PPEN(0) |
> > -				     TMR_TEVENT_ALMEN(0));
> > -		fiper_ctrl |= FIPER_CTRL_DIS(0);
> > -		priv->pps_enabled = false;
> > -		netc_timer_alarm_write(priv, NETC_TMR_DEFAULT_ALARM, 0);
> > +		netc_timer_disable_periodic_pulse(priv, priv->pps_channel);
> > +		priv->fs_alarm_bitmap &= ~BIT(pp->alarm_id);
> 
> You dereference "pp"->alarm_id before assigning "pp" one line below.

oh, sorry, I will fix it in next version.

> 
> > +		pp = &priv->pp[priv->pps_channel];
> > +		memset(pp, 0, sizeof(*pp));
> > +		priv->pps_channel = NETC_TMR_INVALID_CHANNEL;
> >  	}
> >
> > -	netc_timer_wr(priv, NETC_TMR_TEMASK, priv->tmr_emask);
> > -	netc_timer_wr(priv, NETC_TMR_FIPER(0), fiper);
> > -	netc_timer_wr(priv, NETC_TMR_FIPER_CTRL, fiper_ctrl);
> > +unlock_spinlock:
> > +	spin_unlock_irqrestore(&priv->lock, flags);
> > +
> > +	return err;
> > +}