netdev - Re: [PATCH net-next 5/7] staging: octeon: Convert to skb_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025081301-thirsty-battalion-8b01@gregkh>
Date: Wed, 13 Aug 2025 16:20:07 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, ayush.sawal@...lsio.com,
	andrew+netdev@...n.ch, horms@...nel.org, dsahern@...nel.org,
	pablo@...filter.org, kadlec@...filter.org,
	steffen.klassert@...unet.com, mhal@...x.co,
	abhishektamboli9@...il.com, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH net-next 5/7] staging: octeon: Convert to skb_dst_drop

On Tue, Aug 12, 2025 at 08:52:43AM -0700, Stanislav Fomichev wrote:
> Instead of doing dst_release and skb_dst_set, do skb_dst_drop which
> should do the right thing.
> 
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>
> ---
>  drivers/staging/octeon/ethernet-tx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet-tx.c b/drivers/staging/octeon/ethernet-tx.c
> index 261f8dbdc382..0ba240e634a1 100644
> --- a/drivers/staging/octeon/ethernet-tx.c
> +++ b/drivers/staging/octeon/ethernet-tx.c
> @@ -346,8 +346,7 @@ netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev)
>  	 * The skbuff will be reused without ever being freed. We must
>  	 * cleanup a bunch of core things.
>  	 */
> -	dst_release(skb_dst(skb));
> -	skb_dst_set(skb, NULL);
> +	skb_dst_drop(skb);
>  	skb_ext_reset(skb);
>  	nf_reset_ct(skb);
>  	skb_reset_redirect(skb);
> -- 
> 2.50.1
> 
> 

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>