netdev - Re: [PATCH net-next] net: phy: fixed: remove usage of a faux device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250812173810.5603a48a@kernel.org>
Date: Tue, 12 Aug 2025 17:38:10 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>,
 Russell King - ARM Linux <linux@...linux.org.uk>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, David Miller
 <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: fixed: remove usage of a faux device

On Mon, 11 Aug 2025 21:45:49 +0200 Heiner Kallweit wrote:
>  	ret = mdiobus_register(fmb->mii_bus);
>  	if (ret)
> -		goto err_mdiobus_alloc;
> +		mdiobus_free(fmb->mii_bus);
>  
> -	return 0;
> -
> -err_mdiobus_alloc:
> -	mdiobus_free(fmb->mii_bus);
> -err_mdiobus_reg:
> -	faux_device_destroy(fdev);
>  	return ret;
>  }

nit: would you mind leaving the mdiobus_free() where it is?
Feels a little more idiomatic.