netdev - Re: [PATCH net-next v4 2/4] net: phy: micrel: Introduce lanphy_modify_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJ2qwwycF_Ol6726@shell.armlinux.org.uk>
Date: Thu, 14 Aug 2025 10:22:11 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	richardcochran@...il.com, o.rempel@...gutronix.de,
	alok.a.tiwari@...cle.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/4] net: phy: micrel: Introduce
 lanphy_modify_page_reg

On Thu, Aug 14, 2025 at 10:26:22AM +0200, Horatiu Vultur wrote:
> As the name suggests this function modifies the register in an
> extended page. It has the same parameters as phy_modify_mmd.
> This function was introduce because there are many places in the
> code where the registers was read then the value was modified and
> written back. So replace all this code with this function to make
> it clear.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Looks good to me.

Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!