netdev - Re: [PATCH net-next] net/sched: act_api: Remove unnecessary nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250813173450.02715558@kernel.org>
Date: Wed, 13 Aug 2025 17:34:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <horms@...nel.org>, <vladimir.oltean@....com>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net/sched: act_api: Remove unnecessary
 nlmsg_trim()

On Wed, 13 Aug 2025 20:59:15 +0800 Yue Haibing wrote:
> If tca_get_fill() fails, all callers free the skb immediately, no need to
> trim it back to the previous size.

Okay, but why do we care enough to change it?
This is a fairly common pattern in netlink message formatting.
-- 
pw-bot: cr