netdev - Re: [PATCH net-next v4 1/4] net: phy: micrel: Start using PHY_ID_MATCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814094848.ffjslpwlajwaqukf@DEN-DL-M31836.microchip.com>
Date: Thu, 14 Aug 2025 11:48:48 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
CC: <andrew@...n.ch>, <hkallweit1@...il.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<richardcochran@...il.com>, <o.rempel@...gutronix.de>,
	<alok.a.tiwari@...cle.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4 1/4] net: phy: micrel: Start using
 PHY_ID_MATCH_MODEL

The 08/14/2025 10:27, Russell King (Oracle) wrote:

Hi Russell,

> 
> On Thu, Aug 14, 2025 at 10:26:21AM +0200, Horatiu Vultur wrote:
> > Start using PHY_ID_MATCH_MODEL for all the drivers.
> > While at this add also PHY_ID_KSZ8041RNLI to micrel_tbl.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> 
> I'm not sure about this patch. You're subsituting a match that uses
> the desired ID with a mask of 0x00fffff0 with PHY_ID_MATCH_MODEL(id)
> which uses a mask of 0xfffffff0.
> 
> The commit description ought to explain why it is safe to match using
> bits 31:24, whereas the old code was ignoring these bits.

To be honest, I don't know why that old code was ignoring the MSB. I can
see that this has been done like this from 2011. From what I can see the
PHYs has always a value of 0 in the MSB, so I though it would be safe to
update this. Also the MSB contains the Organization Unique Identifier
and I don't think that will change.
I can definetly update the commit message to explain why it is safe to
change the mask.

> 
> Thanks.
> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

-- 
/Horatiu