netdev - Re: [RFC net-next 15/17] net/dibs: Move query_remote_gid() to dibs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed4750cf-fcd7-40b3-be7c-84838cf8fd63@linux.ibm.com>
Date: Thu, 14 Aug 2025 16:49:18 +0200
From: Alexandra Winter <wintera@...ux.ibm.com>
To: Julian Ruess <julianr@...ux.ibm.com>, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "D. Wythe" <alibuda@...ux.alibaba.com>,
        Dust Li <dust.li@...ux.alibaba.com>,
        Sidraya Jayagond <sidraya@...ux.ibm.com>,
        Wenjia Zhang <wenjia@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Thorsten Winkler <twinkler@...ux.ibm.com>,
        Simon Horman <horms@...nel.org>,
        Mahanta Jambigi <mjambigi@...ux.ibm.com>,
        Tony Lu
 <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>,
        Halil Pasic <pasic@...ux.ibm.com>, linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 15/17] net/dibs: Move query_remote_gid() to
 dibs_dev_ops



On 11.08.25 11:34, Julian Ruess wrote:
> On Wed Aug 6, 2025 at 5:41 PM CEST, Alexandra Winter wrote:
>> Provide the dibs_dev_ops->query_remote_gid() in ism and dibs_loopback
>> dibs_devices. And call it in smc dibs_client.
>>
>> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
>> Reviewed-by: Julian Ruess <julianr@...ux.ibm.com>
>> ---
>>  drivers/s390/net/ism_drv.c | 41 +++++++++++++++++---------------------
>>  include/linux/dibs.h       | 14 +++++++++++++
>>  include/net/smc.h          |  2 --
>>  net/dibs/dibs_loopback.c   | 10 ++++++++++
>>  net/smc/smc_ism.c          |  8 ++++++--
>>  net/smc/smc_loopback.c     | 13 ------------
>>  6 files changed, 48 insertions(+), 40 deletions(-)
>>
> 
> -- snip --
> 
>> diff --git a/include/linux/dibs.h b/include/linux/dibs.h
>> index 10be10ae4660..d940411aa179 100644
>> --- a/include/linux/dibs.h
>> +++ b/include/linux/dibs.h
>> @@ -133,6 +133,20 @@ struct dibs_dev_ops {
>>  	 * Return: 2 byte dibs fabric id
>>  	 */
>>  	u16 (*get_fabric_id)(struct dibs_dev *dev);
>> +	/**
>> +	 * query_remote_gid()
>> +	 * @dev: local dibs device
>> +	 * @rgid: gid of remote dibs device
>> +	 * @vid_valid: if zero, vid will be ignored;
>> +	 *	       deprecated, ignored if device does not support vlan
>> +	 * @vid: VLAN id; deprecated, ignored if device does not support vlan
>> +	 *
>> +	 * Query whether a remote dibs device is reachable via this local device
>> +	 * and this vlan id.
>> +	 * Return: 0 if remote gid is reachable.
>> +	 */
>> +	int (*query_remote_gid)(struct dibs_dev *dev, uuid_t *rgid,
>> +				u32 vid_valid, u32 vid);
> 
> Shouldn't this be 'const uuid_t *rgid'?
> 
> -- snip --
> 
> Thanks,
> Julian


Good point. Same for the 'uuid_t *' in signal_event() in
[RFC net-next 17/17] net/dibs: Move event handling to dibs layer
Changed in next version.